feat(buttonMoveIconsIconProp rule): transform to self closing tag #728
Conversation
| if (node.closingElement) { | ||
| const closingSymbol = context | ||
| .getSourceCode() | ||
| .getLastToken(node.openingElement)!; | ||
|
|
||
| fixes.push( | ||
| fixer.replaceText(closingSymbol, " />"), | ||
| fixer.remove(node.closingElement) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Think it would be worth helperizing this? Seems like something that would be useful in a lot of situations.
Though if we do helperize it we should probably add a check to only make an element self closing if it doesn't have any children.
There was a problem hiding this comment.
I added the helper.
About checking that element has no children - this was problematic, because for example in this button rule, we remove the children in a fix and at the same time this fix for removing closing element is applied (so the node still has children at the time the condition is checked). We would have to run the self-closing fix additionaly in a cleanup rule.
So I made the helper customizable where it is not allowed to remove children by default, but it can be overwritten.
adamviktora
force-pushed
the
button-icon-self-closing
branch
from
aa5d7e3 to
49506de
Compare
|
We should wait with merging #735 first. There will be conflicts and the helper will need updates, because we cannot remove all children content in case of non |
- also fixes Icon imported with alias - supports Icon / react-icons being used in children attribute
adamviktora
force-pushed
the
button-icon-self-closing
branch
from
49506de to
cbb89f7
Compare
Closes #694
Also supports Icon / react-icons being used in children attribute.